[ 
https://issues.apache.org/jira/browse/HIVE-11133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992118#comment-15992118
 ] 

Sahil Takiar edited comment on HIVE-11133 at 5/2/17 2:59 AM:
-------------------------------------------------------------

Hey [~xuefuz] I think the the file renames in the patch weren't applied 
properly:

{code}
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Connection.java
similarity index 95%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java
rename to 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/Connection.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java
 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/DagJsonParserUtils.java
similarity index 92%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java
rename to 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/DagJsonParserUtils.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Op.java
similarity index 90%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Op.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Printer.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Printer.java
similarity index 95%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Printer.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Printer.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Stage.java
similarity index 94%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Stage.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Vertex.java
similarity index 81%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Vertex.java
{code}


was (Author: stakiar):
Hey [~xuefuz] I think the the file rename in the patch wasn't applied properly:

{code}
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Connection.java
similarity index 95%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java
rename to 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/Connection.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java
 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/DagJsonParserUtils.java
similarity index 92%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java
rename to 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/DagJsonParserUtils.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Op.java
similarity index 90%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Op.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Printer.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Printer.java
similarity index 95%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Printer.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Printer.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Stage.java
similarity index 94%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Stage.java
diff --git 
a/common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 
b/common/src/java/org/apache/hadoop/hive/common/jsonexplain/Vertex.java
similarity index 81%
rename from 
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java
rename to common/src/java/org/apache/hadoop/hive/common/jsonexplain/Vertex.java
{code}

> Support hive.explain.user for Spark
> -----------------------------------
>
>                 Key: HIVE-11133
>                 URL: https://issues.apache.org/jira/browse/HIVE-11133
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Mohit Sabharwal
>            Assignee: Sahil Takiar
>              Labels: TODOC3.0
>             Fix For: 3.0.0
>
>         Attachments: HIVE-11133.1.patch, HIVE-11133.2.patch, 
> HIVE-11133.3.patch, HIVE-11133.4.patch, HIVE-11133.5.patch, 
> HIVE-11133.6.patch, HIVE-11133.7.patch, HIVE-11133.8.patch, HIVE-11133.9.patch
>
>
> User friendly explain output ({{set hive.explain.user=true}}) should support 
> Spark as well. 
> Once supported, we should also enable related q-tests like {{explainuser_1.q}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to