[
https://issues.apache.org/jira/browse/HIVE-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994484#comment-15994484
]
Rui Li commented on HIVE-16573:
-------------------------------
[~anishek], thanks for the explanations. However, I 'm not sure why we have to
check {{HIVE_SERVER2_INPLACE_PROGRESS}} for spark. Especially that
{{HIVE_SERVER2_INPLACE_PROGRESS}} indicates it only works for tez at the
moment. My understanding is {{InPlaceUpdate.canRenderInPlace}} should only
check {{TEZ_EXEC_INPLACE_PROGRESS}} and {{SPARK_EXEC_INPLACE_PROGRESS}} for tez
and spark respectively. {{HIVE_SERVER2_INPLACE_PROGRESS}} can be checked on top
of this when deciding whether progress bar is enabled for beeline. So I think
we can revert to the code before HIVE-15473. Thoughts?
{code}
String engine = HiveConf.getVar(conf,
HiveConf.ConfVars.HIVE_EXECUTION_ENGINE);
boolean inPlaceUpdates = false;
if (engine.equals("tez")) {
inPlaceUpdates = HiveConf.getBoolVar(conf,
HiveConf.ConfVars.TEZ_EXEC_INPLACE_PROGRESS);
}
if (engine.equals("spark")) {
inPlaceUpdates = HiveConf.getBoolVar(conf,
HiveConf.ConfVars.SPARK_EXEC_INPLACE_PROGRESS);
}
{code}
> In-place update for HoS can't be disabled
> -----------------------------------------
>
> Key: HIVE-16573
> URL: https://issues.apache.org/jira/browse/HIVE-16573
> Project: Hive
> Issue Type: Bug
> Components: Spark
> Reporter: Rui Li
> Assignee: Rui Li
> Priority: Minor
>
> {{hive.spark.exec.inplace.progress}} has no effect
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
