[ 
https://issues.apache.org/jira/browse/HIVE-16469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001073#comment-16001073
 ] 

Barna Zsombor Klara commented on HIVE-16469:
--------------------------------------------

Thanks for the review(s) [~spena], [~Ferd]. I've been struggling with this 
timestamp fix for quite some time, so the help is very much appreciated.
The patch is updated on the review board as well if you want to take another 
look.

> Parquet timestamp table property is not always taken into account
> -----------------------------------------------------------------
>
>                 Key: HIVE-16469
>                 URL: https://issues.apache.org/jira/browse/HIVE-16469
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>         Attachments: HIVE-16469.01.patch, HIVE-16469.02.patch, 
> HIVE-16469.03.patch, HIVE-16469.04.patch, HIVE-16469.05.patch
>
>
> The parquet timestamp timezone property is currently copied over into the 
> JobConf in the FetchOperator, but this may be too late for some execution 
> paths.
> We should:
> 1 - copy the property over earlier
> 2 - set the default value on the JobConf if no property is set, and fail in 
> the ParquetRecordReader if the property is missing from the JobConf
> We should add extra validations for the cases when:
> - the property was not set by accident on the JobConf (unexpected execution 
> path)
> - an incorrect/invalid timezone id is being set on the table



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to