[
https://issues.apache.org/jira/browse/HIVE-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001548#comment-16001548
]
Alan Gates commented on HIVE-16595:
-----------------------------------
It seems that patch 1 does it correctly. Making EOF part of program makes more
sense, since in the future a program might contain multiple blocks. Also
changing it in patch 2 broke a lot of tests. Why the change?
> fix syntax in Hplsql.g4
> -----------------------
>
> Key: HIVE-16595
> URL: https://issues.apache.org/jira/browse/HIVE-16595
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Reporter: Yishuang Lu
> Assignee: Yishuang Lu
> Fix For: 1.2.3
>
> Attachments: HIVE-16595.1.patch, HIVE-16595.2.patch
>
>
> According to https://github.com/antlr/antlr4/issues/118, incorrect error
> message might return if the start rule does not contain an explicit EOF
> transition. It is better to add EOF for the first rule in grammar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
