[ 
https://issues.apache.org/jira/browse/HIVE-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004080#comment-16004080
 ] 

Hive QA commented on HIVE-16589:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12867244/HIVE-16589.02.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5152/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5152/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5152/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2017-05-10 05:15:33.704
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-5152/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2017-05-10 05:15:33.706
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at a113ede HIVE-16330 : Improve plans for scalar subquery with 
aggregates (Vineet Garg via Ashutosh Chauhan)
+ git clean -f -d
Removing data/files/vector_over_example.txt
Removing ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFInfo.java
Removing ql/src/test/queries/clientpositive/vector_outer_reference_windowed.q
Removing ql/src/test/queries/clientpositive/vector_windowing.q
Removing ql/src/test/queries/clientpositive/vector_windowing_expressions.q
Removing ql/src/test/queries/clientpositive/vector_windowing_gby.q
Removing ql/src/test/queries/clientpositive/vector_windowing_gby2.q
Removing ql/src/test/queries/clientpositive/vector_windowing_multipartitioning.q
Removing ql/src/test/queries/clientpositive/vector_windowing_order_null.q
Removing ql/src/test/queries/clientpositive/vector_windowing_range_multiorder.q
Removing ql/src/test/queries/clientpositive/vector_windowing_rank.q
Removing ql/src/test/queries/clientpositive/vector_windowing_streaming.q
Removing ql/src/test/queries/clientpositive/vector_windowing_windowspec.q
Removing ql/src/test/queries/clientpositive/vector_windowing_windowspec4.q
Removing 
ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out
Removing ql/src/test/results/clientpositive/llap/vector_windowing.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_expressions.q.out
Removing ql/src/test/results/clientpositive/llap/vector_windowing_gby.q.out
Removing ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_multipartitioning.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_order_null.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_range_multiorder.q.out
Removing ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_windowspec.q.out
Removing 
ql/src/test/results/clientpositive/llap/vector_windowing_windowspec4.q.out
Removing ql/src/test/results/clientpositive/llap/windowing_windowspec.q.out
Removing ql/src/test/results/clientpositive/vector_ptf_part_simple.q.out
Removing ql/src/test/results/clientpositive/vector_windowing.q.out
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at a113ede HIVE-16330 : Improve plans for scalar subquery with 
aggregates (Vineet Garg via Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2017-05-10 05:15:34.793
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: patch failed: 
ql/src/gen/vectorization/UDAFTemplates/VectorUDAFAvg.txt:459
error: ql/src/gen/vectorization/UDAFTemplates/VectorUDAFAvg.txt: patch does not 
apply
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgDecimal.java:1
error: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgDecimal.java:
 patch does not apply
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgTimestamp.java:1
error: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgTimestamp.java:
 patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out:282
error: ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out: 
patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/llap/vector_join_part_col_char.q.out:111
error: ql/src/test/results/clientpositive/llap/vector_join_part_col_char.q.out: 
patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/llap/vector_non_constant_in_expr.q.out:21
error: 
ql/src/test/results/clientpositive/llap/vector_non_constant_in_expr.q.out: 
patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/llap/vector_string_decimal.q.out:62
error: ql/src/test/results/clientpositive/llap/vector_string_decimal.q.out: 
patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/llap/vectorization_limit.q.out:457
error: ql/src/test/results/clientpositive/llap/vectorization_limit.q.out: patch 
does not apply
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12867244 - PreCommit-HIVE-Build

> Vectorization: Support PARTIAL2, FINAL, and COMPLETE GroupBy modes for AVG
> --------------------------------------------------------------------------
>
>                 Key: HIVE-16589
>                 URL: https://issues.apache.org/jira/browse/HIVE-16589
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-16589.01.patch, HIVE-16589.02.patch
>
>
> Add more classes we vectorize AVG in preparation for fully supporting AVG 
> GroupBy.  In particular, the PARTIAL2 and FINAL groupby modes that take in 
> the AVG struct as input.  And, add the COMPLETE mode that takes in the 
> Original data and produces the Full Aggregation for completeness, so to speak.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to