[
https://issues.apache.org/jira/browse/HIVE-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004458#comment-16004458
]
Peter Vary commented on HIVE-14389:
-----------------------------------
Hi @vihang,
Thanks for the patch. We should clean up the BeeLine output!
Checked the patch, overall it looks good to me, just a few questions:
- Could you please test the cases provided in HIVE-14525
(https://issues.apache.org/jira/browse/HIVE-14525?focusedCommentId=15432183&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15432183)
- I am not really understand why the output is changes
(Pattern.CASE_INSENSITIVE), or why we have to remove the extra spaces around
"nonEscapedSemiColon". Do you know what caused the change?
Other than these, the patch looks good to me.
Thanks,
Peter
> Beeline should not output query and prompt to stdout
> ----------------------------------------------------
>
> Key: HIVE-14389
> URL: https://issues.apache.org/jira/browse/HIVE-14389
> Project: Hive
> Issue Type: Improvement
> Components: Beeline
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Minor
> Attachments: HIVE-14389.01.patch, HIVE-14389.02.patch
>
>
> It seems that the Beeline prints the query along with the results in the
> stdout when a script file is passed. The output file in the example below
> needs to only have the results and not the query.
> {noformat}
> .vihang-MBP:bin vihang$ ./beeline --showheader=false --outformat=tsv2 -u
> "jdbc:hive2://localhost:10000" -f /tmp/query.sql > /tmp/query.out 2>
> /tmp/query.err
> OK
> $ cat /tmp/query.out
> 1: jdbc:hive2://localhost:10000/default> select * from likes limit 4;
> +-----------+--------------+--+
> | 1 | chocolate |
> | 1 | car |
> | 1 | games |
> | 1 | chess |
> +-----------+--------------+--+
> 1: jdbc:hive2://localhost:10000/default>
> 1: jdbc:hive2://localhost:10000/default>
> $
> {noformat}
> A lot of people use HiveCLI and in order to transition from HiveCLI scripts
> to Beeline, this needs to be taken care of. The output files generated by
> beeline should contain only the results and nothing else.
> Similarly, when not in silent mode, query are being printed out on stdout,
> which is adding garbage along with results, as just like HIVE CLI does, users
> would like to have only the results on stdout, not errors/debugging info/etc,
> like the full query.
> Query could be printed out, no problem, as long as it is not on stdout (with
> results), instead, it must be printed out along with the debugging info.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
