[
https://issues.apache.org/jira/browse/HIVE-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005192#comment-16005192
]
Hive QA commented on HIVE-16612:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12867355/HIVE-16612.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10666 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithMr.testFetchResultsOfLogWithPerformanceMode
(batchId=221)
org.apache.hive.service.cli.operation.TestOperationLoggingAPIWithTez.testFetchResultsOfLogWithPerformanceMode
(batchId=220)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5170/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5170/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5170/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12867355 - PreCommit-HIVE-Build
> PerfLogger is configurable, but not extensible
> ----------------------------------------------
>
> Key: HIVE-16612
> URL: https://issues.apache.org/jira/browse/HIVE-16612
> Project: Hive
> Issue Type: Bug
> Components: Query Planning, Query Processor
> Reporter: Remus Rusanu
> Assignee: Remus Rusanu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HIVE-16612.01.patch, HIVE-16612.02.patch
>
>
> {code}
> result = (PerfLogger)
> ReflectionUtils.newInstance(conf.getClassByName(
> conf.getVar(HiveConf.ConfVars.HIVE_PERF_LOGGER)), conf);
> {code}
> The PerfLogger instance is configurable via {{hive.exec.perf.logger}}
> (HIVE-11891) but the requirement to extend from {{PerfLogger}} cannot be met
> since HIVE-11149 as the ctor is private. Also useful methods in PerfLogger
> are also private. I tried to extend PerfLogger for my needs and realized
> that, as is, the configurability is not usable. At the very least the
> PerfLogger should make all private members {{protected}}, better the
> requirement should be an interface not a class.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
