[ 
https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated HIVE-15051:
------------------------------
    Attachment: HIVE-15051.patch

Integrated Apache Yetus (https://yetus.apache.org/)
- Created hive personality to contain the hive specific configurations
- Created yetus-wrapper.sh to download yetus and patch the not yet released 
changes:
-- checkstyle_YETUS-484.sh
-- findbugs_YETUS-471.sh
-- maven_YETUS-506.sh
- Created test-patch.sh, and smart-apply-patch.sh to simplify testing/applying 
patch
- Added patchprocess directory to gitignore
- Two small modification in pom.xml
-- Adding findbugs configuration to build
-- Disabling failure on javadoc errors

Currently this could be run manually from command line:
To test a patch set the FINDBUGS_HOME, and go to the hive source root directory 
and run the test_patch.sh command like this:
{code}
./[petervary:~/dev/upstream/hive] $ export 
FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh 
~/Downloads/HIVE-16345.2.patch
{code}

> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
>                 Key: HIVE-15051
>                 URL: https://issues.apache.org/jira/browse/HIVE-15051
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: beeline.out, HIVE-15051.patch, Interim.patch, ql.out
>
>
> Find a way to integrate code analysis tools like findbugs, rat checks to 
> PreCommit tests, thus removing the burden from reviewers to check the code 
> style and other checks which could be done by code. 
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific 
> parallel test framework.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to