[
https://issues.apache.org/jira/browse/HIVE-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014920#comment-16014920
]
Sushanth Sowmyan commented on HIVE-16684:
-----------------------------------------
Sankar, a couple of comments and questions:
a) I was wondering if checking for InvalidTableException was sufficient, and
what happens when individual partitions in a table are dropped, since they have
a similar problem. However, that issue is not as easy to fix, and might need a
separate jira for it - for that scenario, PartitionIterable might need to be
updated, so as to allow it to configurably "skip over" partitions if it does
not find them at batch-fetch time, and then, call that form of
PartitionIterable from EximUtil. Note that this is not to say that this patch
needs to be updated for it, merely that that is another open issue that needs
addressing that is similar to this.
b) For DummyRawStoreForRepl, it is possible that due to retries/etc, getTable
is actually called multiple times for a single call. Thus, for this test to be
robust, rather than the getTable call toggling back shouldGetTableSucceed after
the 1 failed call, it might make more sense to explicitly require the test to
call setGetTableSucceed again to turn it back to true.
c) Also, I'm not convinced that the name of the DummyRawStoreForRepl is
descriptive - maybe something like InjectableBehaviourRawStore ? Then it's also
possible that at some time in the future, we make this more generic by allowing
Function injection to change behaviours of individual functions apart from just
getTable(For now, I'd retain it at your current behaviour).
> Bootstrap REPL DUMP shouldn't fail when table is dropped after fetching the
> table names.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-16684
> URL: https://issues.apache.org/jira/browse/HIVE-16684
> Project: Hive
> Issue Type: Sub-task
> Components: Hive, repl
> Affects Versions: 2.1.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Attachments: HIVE-16684.01.patch
>
>
> Currently, bootstrap dump will fail if the table does't exist when try to
> dump. This shall occur when table is dropped after REPL DUMP fetched the
> table names.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
