[
https://issues.apache.org/jira/browse/HIVE-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016175#comment-16016175
]
Siddharth Seth commented on HIVE-13673:
---------------------------------------
+1 Looks good.
Minor: Probably better to create the random instance up front, if
BaseInputFormat is likely to be used multiple times, and especially if it's
from different threads.
The way this is handled for Hive queries, the next node isn't exactly random.
There's sequencing involved to increases the chances of a cache hit.
https://github.com/apache/hive/blob/master/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java#L831
I think it's worth creating a follow up jira to use this approach.
> LLAP: handle case where no service instance is found on the host specified in
> the input split
> ---------------------------------------------------------------------------------------------
>
> Key: HIVE-13673
> URL: https://issues.apache.org/jira/browse/HIVE-13673
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-13673.1.patch
>
>
> From [~sseth] on review of HIVE-13620, in regards to
> LlapBaseInputFormat.getServiceInstance() and how to handle the case of no
> LLAP service instance for the host specified in the LLAP input split:
> {quote}
> This should really be a jira and TODO (post merge to master) - to either 1)
> go to an alternate random address from the available llap instances, or 2)
> have additional locations provided by HS2.
> I'd lean towards 1. It's absolutely possible for an llap instance to go down,
> or the node to go down, which would end up causing failures.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
