[ 
https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022815#comment-16022815
 ] 

Zoltan Haindrich commented on HIVE-15051:
-----------------------------------------

[~pvary]: There is some issue with the current working of this patch...if I 
don't have hive already installed at the local {{.m2}} it doesn't really work - 
because it refers to some hive artifacts which are not yet installed...I don't 
entirely understand the concept behind executing {{mvn install}} only in just 
the changed modules ( this seems to me an interesting idea to do in a multi 
module project ).
Anyway adding {{mvn install -DskipTests -DskipSparkTests}} to the test-patch.sh 
have fixed this for me - leaving this out may result in unrelated compile 
errors...which might be misleading.

note: the usage of the tool requires a clean workspace; however the cleanup is 
left for the user...which is a bit odd; or this is normal behaviour?

> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
>                 Key: HIVE-15051
>                 URL: https://issues.apache.org/jira/browse/HIVE-15051
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: beeline.out, HIVE-15051.patch, Interim.patch, ql.out
>
>
> Find a way to integrate code analysis tools like findbugs, rat checks to 
> PreCommit tests, thus removing the burden from reviewers to check the code 
> style and other checks which could be done by code. 
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific 
> parallel test framework.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to