[
https://issues.apache.org/jira/browse/HIVE-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024454#comment-16024454
]
Jesus Camacho Rodriguez edited comment on HIVE-16474 at 5/25/17 9:35 AM:
-------------------------------------------------------------------------
[~nishantbangarwa], I have a last remark. Could you add a comment to the new
static block in DruidOutputFormat.java explaining why you are injecting the
_SelectQueryConfig_ (and e.g. you are not injecting config objects for other
type of queries)?
Also some comments in _HiveDruidSerializationModule_ to know its purpose would
be good to have. Thanks
was (Author: jcamachorodriguez):
[~nishantbangarwa], I have a last remark. Could you add a comment to the new
static block in DruidOutputFormat.java explaining why you are injecting the
_SelectQueryConfig_ (and e.g. you are not injecting config objects for other
type of queries)?
Also some comments in _HiveDruidSerializationModule_ to know its purpose would
be good to have.
> Upgrade Druid version to 0.10
> -----------------------------
>
> Key: HIVE-16474
> URL: https://issues.apache.org/jira/browse/HIVE-16474
> Project: Hive
> Issue Type: Task
> Components: Druid integration
> Reporter: Ashutosh Chauhan
> Assignee: Nishant Bangarwa
> Attachments: HIVE-16474.01.patch, HIVE-16474.02.patch,
> HIVE-16474.03.patch, HIVE-16474.04.patch, HIVE-16474.05.patch,
> HIVE-16474.patch
>
>
> Druid 0.10 is out. We shall upgrade to it to take advantage of improvements
> it brings.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
