[
https://issues.apache.org/jira/browse/HIVE-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046498#comment-16046498
]
Barna Zsombor Klara edited comment on HIVE-14746 at 6/12/17 2:02 PM:
---------------------------------------------------------------------
[~spena]
I'm not sure I understand the reasoning behind removing the repository url from
the profile. I get why branch would be useful, but do we ever run tests which
aren't in {{https://github.com/apache/hive.git}}? How likely is the scenario
that we will like to test against not only different branches but also against
different repositories?
I can take it out from the profile but since repo type and repo name are there
I would expect the url to be there in the profile too. And moving all three out
will start making the PTestClient invocation very cumbersome.
I suggest to only move the branch name into a parameter, but ultimately I will
defer to you.
was (Author: zsombor.klara):
[~spena]
I'm not sure I understand the reasoning behing removing the repository url from
the profile. I get why branch would be useful, but do we ever run tests which
aren't in {{https://github.com/apache/hive.git}}? How likely is the scenario
that we will like to test against not only different branches but also against
different repositories?
I can take it out from the profile but since repo type and repo name are there
I would expect the url to be there in the profile too. And moving all three out
will start making the PTestClient invocation very cumbersome.
I suggest to only move the branch name into a parameter, but ultimately I will
defer to you.
> Remove branch and repositories from profiles by sending them from ptest-client
> ------------------------------------------------------------------------------
>
> Key: HIVE-14746
> URL: https://issues.apache.org/jira/browse/HIVE-14746
> Project: Hive
> Issue Type: Sub-task
> Components: Hive, Testing Infrastructure
> Reporter: Sergio Peña
> Assignee: Barna Zsombor Klara
>
> Hive ptest uses some properties files per branch that contain information
> about how to execute the tests.
> This profile includes the branch name and repository URLs used to fetch the
> branch code. We should get rid of these by detecting the branch from the
> jenkins-execute-build.sh script, and send the information directly to
> ptest-server as command line parameters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
