[ 
https://issues.apache.org/jira/browse/HIVE-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070650#comment-16070650
 ] 

Sergio Peña commented on HIVE-16759:
------------------------------------

[~janulatha] This patch is adding a new extra information to Thrift and the JDO 
objects, but I don't see any change on the schema definitions for them.

package.jdo is for DB definition (search for MNotificationLog)
hive_metastore.thrift is for Thrift definition (search for NotificationEvent)

Anyway, I don't know if it would be a good approach to change those definitions 
just to add a table type. We can add them as part of the message built on the 
DbNotificationListener, such as buildCreateTableMessage(). I saw this is 
already serializing the table information, but the problem is that when we 
deserialize it, we don't get the table type. See the JSONCreateTableMessage 
class, it contains information about create table that is part of the message.

That would be better and more compatible.

> Add table type information to HMS log notifications
> ---------------------------------------------------
>
>                 Key: HIVE-16759
>                 URL: https://issues.apache.org/jira/browse/HIVE-16759
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 2.1.1
>            Reporter: Sergio Peña
>            Assignee: Janaki Lahorani
>         Attachments: HIVE16759.1.patch
>
>
> The DB notifications used by HiveMetaStore should include the table type for 
> all notifications that include table events, such as create, drop and alter 
> table.
> This would be useful for consumers to identify views vs tables.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to