[
https://issues.apache.org/jira/browse/HIVE-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070854#comment-16070854
]
Malcolm Taylor commented on HIVE-16989:
---------------------------------------
Fix the following alerts:
1. Container contents are never accessed:
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java
2. Equals method does not inspect argument type:
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java
3. Self assignment:
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java
4. Cast from abstract to concrete collection:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java
5-7. Close input resource:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
beeline/src/java/org/apache/hive/beeline/BeeLine.java
8-13. Close database resource:
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java
14. Subtle call to inherited method:
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java
> Fix some issues identified by lgtm.com
> --------------------------------------
>
> Key: HIVE-16989
> URL: https://issues.apache.org/jira/browse/HIVE-16989
> Project: Hive
> Issue Type: Improvement
> Reporter: Malcolm Taylor
> Assignee: Malcolm Taylor
> Attachments: HIVE-16989.patch
>
>
> [lgtm.com|https://lgtm.com] has identified a number of issues where there may
> be scope for improvement. The plan is to address some of the alerts found at
> [https://lgtm.com/projects/g/apache/hive/].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
