[
https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080078#comment-16080078
]
Peter Vary commented on HIVE-15051:
-----------------------------------
Thanks for the review [~leftylev]!
Added the fix version, thanks for pointing that out!
My answers:
??What does this phrase mean in paragraph 3: "... no full refactoring is
required for change ..."? I guess what puzzles me is the "for change" part.??
I was trying to emphasize that Yetus checks only the changed part of the code.
So if the unchanged part contains errors, then Yetus will not report it. I am
*very* open for better wording :D
??Why did you omit maven and javac from the Hive personality list, although
they are in personality_plugins (dev-support/hive-personality.sh)??
They are needed for running Yetus:
- Maven tells Yetus, that it should use maven to build the the code.
- Javac tells Yetus, how to generate the compile output
Thanks,
Peter
> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
> Key: HIVE-15051
> URL: https://issues.apache.org/jira/browse/HIVE-15051
> Project: Hive
> Issue Type: Sub-task
> Components: Testing Infrastructure
> Reporter: Peter Vary
> Assignee: Peter Vary
> Fix For: 3.0.0
>
> Attachments: beeline.out, HIVE-15051.02.patch, HIVE-15051.patch,
> Interim.patch, ql.out
>
>
> Find a way to integrate code analysis tools like findbugs, rat checks to
> PreCommit tests, thus removing the burden from reviewers to check the code
> style and other checks which could be done by code.
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific
> parallel test framework.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
