[ 
https://issues.apache.org/jira/browse/HIVE-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086448#comment-16086448
 ] 

Eugene Koifman commented on HIVE-14988:
---------------------------------------

+1 LGTM

FYI, it may be easier to check for files names like this using 
INPUT__FILE__NAME VirtualColumn, for example 
TestTxnCommands.testNonAcidToAcidConversion01()

It may be good to move the 2 new tests in TestTxnCommands2 to TestTxnCommands.  
The former has 2 subclasses which rerun all the tests in Split Update mode and 
vectorized mode.  I don't think there is value in that for these tests - just 
adds to runtime.  

This can be done in later.



> Support INSERT OVERWRITE into a partition on transactional tables
> -----------------------------------------------------------------
>
>                 Key: HIVE-14988
>                 URL: https://issues.apache.org/jira/browse/HIVE-14988
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Wei Zheng
>         Attachments: HIVE-14988.01.patch, HIVE-14988.02.patch, 
> HIVE-14988.03.patch, HIVE-14988.04.patch, HIVE-14988.05.patch, 
> HIVE-14988.06.patch
>
>
> Insert overwrite operation on transactional table will currently raise an 
> error.
> This can/should be supported



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to