[
https://issues.apache.org/jira/browse/HIVE-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091745#comment-16091745
]
Alan Gates commented on HIVE-17069:
-----------------------------------
A couple of questions around OriginalReaderPairToCompact.
# I'm missing what's different here that requires a new implementation.
# I didn't see any tests that exercise this implementation (maybe I just missed
it)
> Refactor OrcRawRecrodMerger.ReaderPair
> --------------------------------------
>
> Key: HIVE-17069
> URL: https://issues.apache.org/jira/browse/HIVE-17069
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: Eugene Koifman
> Attachments: HIVE-17069.01.patch, HIVE-17069.02.patch,
> HIVE-17069.03.patch
>
>
> this should be done post HIVE-16177 so as not to obscure the functional
> changes completely
> Make ReaderPair an interface
> ReaderPairImpl - will do what ReaderPair currently does, i.e. handle "normal"
> code path
> OriginalReaderPair - same as now but w/o incomprehensible override/variable
> shadowing logic.
> Perhaps split it into 2 - 1 for compaction 1 for "normal" read with common
> base class.
> Push discoverKeyBounds() into appropriate implementation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
