[
https://issues.apache.org/jira/browse/HIVE-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091944#comment-16091944
]
Aihua Xu commented on HIVE-16974:
---------------------------------
That looks good.
One suggestion: I'm wondering if "order by name, id" would be better since such
output especially failed ones will be checked manually as well. It would be
hard to check against id. The order of the output should also be in
deterministic order, right?
> Change the sort key for the schema tool validator to be <ID>
> ------------------------------------------------------------
>
> Key: HIVE-16974
> URL: https://issues.apache.org/jira/browse/HIVE-16974
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Affects Versions: 3.0.0
> Reporter: Naveen Gangam
> Assignee: Naveen Gangam
> Attachments: HIVE-16974.patch, HIVE-16974.patch
>
>
> In HIVE-16729, we introduced ordering of results/failures returned by
> schematool's validators. This allows fault injection testing to expect
> results that can be verified. However, they were sorted on NAME values which
> in the HMS schema can be NULL. So if the introduced fault has a NULL/BLANK
> name column value, the result could be different depending on the backend
> database(if they sort NULLs first or last).
> So I think it is better to sort on a non-null column value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
