[ https://issues.apache.org/jira/browse/HIVE-17111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092672#comment-16092672 ]
Rui Li commented on HIVE-17111: ------------------------------- Hi [~stakiar], [~csun], there was some issue specific to yarn-cluster mode, like HIVE-9425 and HIVE-12045. I'm not rushing to move from TestSparkCliDriver to TestMiniSparkOnYarnCliDriver. But basically, I think it's better to keep our tests close to real use case. BTW, even with local-cluster, the executors are still run in separate JVMs, so we can't have everything in process. > TestSparkCliDriver does not use LocalHiveSparkClient > ---------------------------------------------------- > > Key: HIVE-17111 > URL: https://issues.apache.org/jira/browse/HIVE-17111 > Project: Hive > Issue Type: Bug > Components: Spark > Reporter: Sahil Takiar > Assignee: Sahil Takiar > > The TestSparkCliDriver sets the spark.master to local-cluster[2,2,1024] but > the HoS still uses decides to use the RemoteHiveSparkClient rather than the > LocalHiveSparkClient. > The issue is with the following check in HiveSparkClientFactory: > {code} > if (master.equals("local") || master.startsWith("local[")) { > // With local spark context, all user sessions share the same spark > context. > return LocalHiveSparkClient.getInstance(generateSparkConf(sparkConf)); > } else { > return new RemoteHiveSparkClient(hiveconf, sparkConf); > } > {code} > When {{master.startsWith("local[")}} it checks the value of spark.master and > sees that it doesn't start with {{local[}} and then decides to use the > RemoteHiveSparkClient. > We should fix this so that the LocalHiveSparkClient is used. It should speed > up some of the tests, and also makes qtests easier to debug since everything > will now be run in the same process. -- This message was sent by Atlassian JIRA (v6.4.14#64029)