[
https://issues.apache.org/jira/browse/HIVE-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095759#comment-16095759
]
Rui Li commented on HIVE-17034:
-------------------------------
Hi [~kgyrtkirk], the change here only affects the "re-download" logic:
{code}
if [[ ! -f $DOWNLOAD_DIR/$tarName ]]
then
curl -Sso $DOWNLOAD_DIR/$tarName $url
else
local md5File="$tarName".md5sum
curl -Sso $DOWNLOAD_DIR/$md5File "$url".md5sum
cd $DOWNLOAD_DIR
if type md5sum >/dev/null && ! md5sum -c $md5File; then
curl -Sso $DOWNLOAD_DIR/$tarName $url || return 1
fi
{code}
If the tar doesn't exist in the first place, it'll be downloaded anyway.
For "re-download", if the developer really cares about updating the spark tar,
I assume he/she will be aware that md5sum is needed. Does that make sense?
> The spark tar for itests is downloaded every time if md5sum is not installed
> ----------------------------------------------------------------------------
>
> Key: HIVE-17034
> URL: https://issues.apache.org/jira/browse/HIVE-17034
> Project: Hive
> Issue Type: Test
> Components: Spark
> Reporter: Rui Li
> Assignee: Rui Li
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HIVE-17034.1.patch
>
>
> I think we should either skip verifying md5, or fail the build to let
> developer know md5sum is required.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
