[
https://issues.apache.org/jira/browse/HIVE-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108352#comment-16108352
]
Xuefu Zhang commented on HIVE-17213:
------------------------------------
Patch #1 looks good. However, I'd suggest the following:
1. Code style for
{code}
+ for (FileSinkDesc fsConf:fileSinkDesc.getLinkedFileSinkDesc()) {
+ fsConf.setDirName(tmpDir);
{code}
2. Possibly add a test
Also, I'd like to understand a bit more and this will be conducted in person.
> HoS: file merging doesn't work for union all
> --------------------------------------------
>
> Key: HIVE-17213
> URL: https://issues.apache.org/jira/browse/HIVE-17213
> Project: Hive
> Issue Type: Bug
> Components: Spark
> Reporter: Chao Sun
> Assignee: Chao Sun
> Attachments: HIVE-17213.0.patch, HIVE-17213.1.patch
>
>
> HoS file merging doesn't work properly since it doesn't set linked file sinks
> properly which is used to generate move tasks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
