Jesus Camacho Rodriguez commented on HIVE-16945:

[~lirui], sorry for taking this long to review.

Patch LGTM. Knitpick: could you add null check for {{other.getConf()}} in 
{{logicalEquals}} method? Thanks

> Add method to compare Operators 
> --------------------------------
>                 Key: HIVE-16945
>                 URL: https://issues.apache.org/jira/browse/HIVE-16945
>             Project: Hive
>          Issue Type: Improvement
>          Components: Operators
>    Affects Versions: 3.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Rui Li
>         Attachments: HIVE-16945.1.patch, HIVE-16945.2.patch
> HIVE-10844 introduced a comparator factory class for operators that 
> encapsulates all the logic to assess whether two operators are equal:
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/OperatorComparatorFactory.java
> The current design might create problems as any change in fields of operators 
> will break the comparators. It would be better to do this via inheritance 
> from Operator base class, by adding a {{logicalEquals(Operator other)}} 
> method.

This message was sent by Atlassian JIRA

Reply via email to