[ 
https://issues.apache.org/jira/browse/HIVE-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128613#comment-16128613
 ] 

ASF GitHub Bot commented on HIVE-17331:
---------------------------------------

GitHub user dosoft opened a pull request:

    https://github.com/apache/hive/pull/233

    HIVE-17331: Use Path instead of String as key type of the pathToAliases

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dosoft/hive HIVE-17331

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #233
    
----
commit 23a947dd0aaaf7a9d9838c0972d7b46c9ba83e00
Author: Oleg Danilov <[email protected]>
Date:   2017-08-16T10:34:39Z

    HIVE-17331: Use Path instead of String as key type of the pathToAliases

----


> Path must be used as key type of the pathToAlises
> -------------------------------------------------
>
>                 Key: HIVE-17331
>                 URL: https://issues.apache.org/jira/browse/HIVE-17331
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>
> # This code uses String instead of Path as key type of the pathToAliases map, 
> so seems like get(String) always null.
> +*GenMapRedUtils.java*+
> {code:java}
>         for (int pos = 0; pos < size; pos++) {
>           String taskTmpDir = taskTmpDirLst.get(pos);
>           TableDesc tt_desc = tt_descLst.get(pos);
>           MapWork mWork = plan.getMapWork();
>           if (mWork.getPathToAliases().get(taskTmpDir) == null) {
>             taskTmpDir = taskTmpDir.intern();
>             Path taskTmpDirPath = 
> StringInternUtils.internUriStringsInPath(new Path(taskTmpDir));
>             mWork.removePathToAlias(taskTmpDirPath);
>             mWork.addPathToAlias(taskTmpDirPath, taskTmpDir);
>             mWork.addPathToPartitionInfo(taskTmpDirPath, new 
> PartitionDesc(tt_desc, null));
>             mWork.getAliasToWork().put(taskTmpDir, topOperators.get(pos));
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to