[ https://issues.apache.org/jira/browse/HIVE-17313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130079#comment-16130079 ]
Zoltan Haindrich commented on HIVE-17313: ----------------------------------------- did it cause any known problems ? +1 seems like the jenkins logs are already removed....the org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDate2 might be related.... > Potentially possible 'case fall through' in the ObjectInspectorConverters > ------------------------------------------------------------------------- > > Key: HIVE-17313 > URL: https://issues.apache.org/jira/browse/HIVE-17313 > Project: Hive > Issue Type: Bug > Reporter: Oleg Danilov > Assignee: Oleg Danilov > Priority: Trivial > Attachments: HIVE-17313.patch > > > Lines 103-110: > {code:java} > case STRING: > if (outputOI instanceof WritableStringObjectInspector) { > return new PrimitiveObjectInspectorConverter.TextConverter( > inputOI); > } else if (outputOI instanceof JavaStringObjectInspector) { > return new PrimitiveObjectInspectorConverter.StringConverter( > inputOI); > } > case CHAR: > {code} > De-facto it should work correctly since outputOI is either an instance of > WritableStringObjectInspector or JavaStringObjectInspector, but it would be > better to rewrite this case to avoid possible fall through. -- This message was sent by Atlassian JIRA (v6.4.14#64029)