[ 
https://issues.apache.org/jira/browse/HIVE-17455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154674#comment-16154674
 ] 

Sergey Shelukhin commented on HIVE-17455:
-----------------------------------------

nit: the map should be final.
Also, LlapBaseInputFormat.close/closeAll do not appear to be called outside of 
test.
I wonder about bugs/leaks that may result from not calling close... should 
there be expiration?

> External LLAP client: connection to HS2 should be kept open until explicitly 
> closed
> -----------------------------------------------------------------------------------
>
>                 Key: HIVE-17455
>                 URL: https://issues.apache.org/jira/browse/HIVE-17455
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-17455.1.patch
>
>
> In the case that a complex query (aggregation/join) is passed to external 
> LLAP client, the query result is first saved as a Hive temp table before 
> being read by LLAP to client. Currently the HS2 connection used to fetch the 
> LLAP splits is closed right after the splits are fetched, which means the 
> temp table is gone by the time LLAP tries to read it.
> Try to keep the connection open so that the table is still around when LLAP 
> tries to read it. Add close methods which can be used to close the connection 
> when the client is done with the query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to