[
https://issues.apache.org/jira/browse/HIVE-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156046#comment-16156046
]
Siddharth Seth commented on HIVE-17431:
---------------------------------------
{code}
refreshLocalResourcesFromConf(conf);
{code}
in openInternal seems to be a potential problem area. Either it is missing LRs
for the new session, or this code should not exist anymore.
For the most part, I suspect some of the other parameters in this class can be
made final as well.
Unrelated to the patch:
- There's places where the queue apparently gets changed from TezSessionPool.
Didn't know a single SessionState could be moved across queues. Seems
unnecessary.
- replaceSession - maybe simpler to move the implementation into
TezSessionState itself. e.g. additionLocalResourcesNotFromConf is fetched and
then passed back in to the open method...
> change configuration handling in TezSessionState
> ------------------------------------------------
>
> Key: HIVE-17431
> URL: https://issues.apache.org/jira/browse/HIVE-17431
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-17431.patch
>
>
> The configuration is only set when opening the session; that seems
> unnecessary - it could be set in the ctor and made final. E.g. when updating
> the session and localizing new resources we may theoretically open the
> session with a new config, but we don't update the config and only update the
> files if the session is already open, which seems to imply that it's ok to
> not update the config.
> In most cases, the session is opened only once or reopened without intending
> to change the config (e.g. if it times out).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
