[
https://issues.apache.org/jira/browse/HIVE-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160836#comment-16160836
]
Zoltan Haindrich commented on HIVE-17338:
-----------------------------------------
some minor notices:
* the new method retained the "mrTasks" variable name...however; I think it now
has nothing to do with mr
* I think it might be possible to merge the 2 {{getTasks}} methods into one.
* its a bit confusing what happens in the 2 arg {{getTasks()}} ... the
{{tasks}} variable is reassigned to the return value of the other - and never
used again... I think this is 1-more reason to merge them :)
> Utilities.get*Tasks multiple methods duplicate code
> ---------------------------------------------------
>
> Key: HIVE-17338
> URL: https://issues.apache.org/jira/browse/HIVE-17338
> Project: Hive
> Issue Type: Bug
> Reporter: Thejas M Nair
> Assignee: Gergely Hajós
> Attachments: HIVE-17338.1.patch
>
>
> As discussed in https://github.com/apache/hive/pull/212/files, the 3
> functions can share a more general function.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
