[
https://issues.apache.org/jira/browse/HIVE-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172788#comment-16172788
]
ASF GitHub Bot commented on HIVE-17561:
---------------------------------------
GitHub user alanfgates opened a pull request:
https://github.com/apache/hive/pull/253
HIVE-17561
Moved TxnStore and its implementations. Moved DataSourceProvider as well.
Moved ValidTxnList and ValidReadTxnList to storage-api as ORC and the
standalone metastore will both need them. Also moved the newly created
SQLGenerator.
I did not move the functionality that added bonecp and hikari to the
restricted list in HiveConf because MetastoreConf doesn't have a restricted
list. MetastoreConf doesn't have a restricted list because that functionality
is broken. setVar* doesn't check against the restricted list. Given that
MetastoreConf is a set of static convenience methods to be used on top of
Configuration we can't stop users from going underneath and calling set()
directly anyway. If we want to restrict users from setting certain values in
the MetastoreConf we need a comprehensive and secure way to do it. Plus I'm
not convinced that boncep and hikari settings are high security issues anyway.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alanfgates/hive hive17561
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hive/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit 305c8f27e884c94faad34a350eeeeee1848cdd5f
Author: Alan Gates <[email protected]>
Date: 2017-08-04T20:02:03Z
WIP, tests don't pass yet. I think I've moved all the files.
commit 21523f3dfd0666a3ef68558a392df14c0bf80eb0
Author: Alan Gates <[email protected]>
Date: 2017-09-20T06:01:25Z
Moved SQLGenerator since it was newly created. I did not move the
functionality that added bonecp and hikari to the restricted list in HiveConf,
because there is no restricted list in MetastoreConf. There's no restricted
list because the HiveConf implementation is completely broken. It isn't
checked when a setVar call is made, so it's easy to end run around. If we want
to figure out ways to restrict what values users can set at runtime we need to
do it in a coherent and complete way.
----
> Move TxnStore and implementations to standalone metastore
> ---------------------------------------------------------
>
> Key: HIVE-17561
> URL: https://issues.apache.org/jira/browse/HIVE-17561
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore, Transactions
> Reporter: Alan Gates
> Assignee: Alan Gates
> Labels: pull-request-available
>
> We need to move the metastore handling of transactions into the standalone
> metastore.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
