[
https://issues.apache.org/jira/browse/HIVE-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Koifman updated HIVE-17691:
----------------------------------
Description:
# DDLSemanticAnalyzer.alterTableOutput is unused
# DDLTask.generateAddMmTasks(Table) - stmtId should probably come from
TransactionManager
# DDLTask.createTable(Hive db, CreateTableDesc crtTbl) has _Long mmWriteId =
crtTbl.getInitialMmWriteId();_ logic is unclear.. this ID is only set in one
place..
# FileSinkOperator has multiple places that look like _conf.getWriteType() ==
AcidUtils.Operation.NOT_ACID || conf.isMmTable()_ - what is the writeType for
MM tables? Seems that Wei opted for "work.getLoadTableWork().getWriteType() !=
AcidUtils.Operation.NOT_ACID && !tbd.isMmTable()" to mean MM, e.g.
MoveTask.handleStaticParts() call to Hive.loadPartition()
# HiveConf.HIVE_TXN_OPERATIONAL_PROPERTIES - the doc/explanation there is
obsolete
# Compactor Initiator likely doesn't work for MM tables. It's triggered by
into in TXN_COMPONENTS/COMPLETED_TXN_COMPONENTS. MM tables don't write to
either because DbTxnManager.acquireLocks() does
_compBuilder.setIsAcid(AcidUtils.isFullAcidTable(t));_ i.e. it treats MM as
non-acid tables
# In general integration with full Acid seems confused wrt to MM and seems to
treat MM as special table type rather than subtype of Acid table. (mostly, but
not always).
was:
# DDLSemanticAnalyzer.alterTableOutput is unused
# DDLTask.generateAddMmTasks(Table) - stmtId should probably come from
TransactionManager
# DDLTask.createTable(Hive db, CreateTableDesc crtTbl) has _Long mmWriteId =
crtTbl.getInitialMmWriteId();_ logic is unclear.. this ID is only set in one
place..
# FileSinkOperator has multiple places that look like _conf.getWriteType() ==
AcidUtils.Operation.NOT_ACID || conf.isMmTable()_ - what is the writeType for
MM tables? Seems that Wei opted for "work.getLoadTableWork().getWriteType() !=
AcidUtils.Operation.NOT_ACID && !tbd.isMmTable()" to mean MM, e.g.
MoveTask.handleStaticParts() call to Hive.loadPartition()
# HiveConf.HIVE_TXN_OPERATIONAL_PROPERTIES - the doc/explanation there is
obsolete
# Compactor Initiator likely doesn't work for MM tables. It's triggered by
into in TXN_COMPONENTS/COMPLETED_TXN_COMPONENTS. MM tables don't write to
either because DbTxnManager.acquireLocks() does
_compBuilder.setIsAcid(AcidUtils.isFullAcidTable(t));_ i.e. it treats MM as
non-acid tables
> Misc Nits
> ---------
>
> Key: HIVE-17691
> URL: https://issues.apache.org/jira/browse/HIVE-17691
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Reporter: Eugene Koifman
>
> # DDLSemanticAnalyzer.alterTableOutput is unused
> # DDLTask.generateAddMmTasks(Table) - stmtId should probably come from
> TransactionManager
> # DDLTask.createTable(Hive db, CreateTableDesc crtTbl) has _Long mmWriteId =
> crtTbl.getInitialMmWriteId();_ logic is unclear.. this ID is only set in one
> place..
> # FileSinkOperator has multiple places that look like _conf.getWriteType() ==
> AcidUtils.Operation.NOT_ACID || conf.isMmTable()_ - what is the writeType for
> MM tables? Seems that Wei opted for "work.getLoadTableWork().getWriteType()
> != AcidUtils.Operation.NOT_ACID && !tbd.isMmTable()" to mean MM, e.g.
> MoveTask.handleStaticParts() call to Hive.loadPartition()
> # HiveConf.HIVE_TXN_OPERATIONAL_PROPERTIES - the doc/explanation there is
> obsolete
> # Compactor Initiator likely doesn't work for MM tables. It's triggered by
> into in TXN_COMPONENTS/COMPLETED_TXN_COMPONENTS. MM tables don't write to
> either because DbTxnManager.acquireLocks() does
> _compBuilder.setIsAcid(AcidUtils.isFullAcidTable(t));_ i.e. it treats MM as
> non-acid tables
> # In general integration with full Acid seems confused wrt to MM and seems to
> treat MM as special table type rather than subtype of Acid table. (mostly,
> but not always).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
