[
https://issues.apache.org/jira/browse/HIVE-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Voros updated HIVE-17725:
--------------------------------
Attachment: HIVE-17725.1.patch
Attaching patch #1. This renames the following tests:
{code}
./hbase-handler/src/test/org/apache/hadoop/hive/hbase/LazyHBaseCellMapTest.java
./hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/HCatBaseTest.java
./itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/ThriftCliServiceMessageSizeTest.java
./jdbc/src/test/org/apache/hive/jdbc/HiveStatementTest.java
./jdbc-handler/src/test/java/org/apache/hive/config/JdbcStorageConfigManagerTest.java
./jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessorTest.java
./jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/JdbcInputFormatTest.java
./jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/QueryConditionBuilderTest.java
./metastore/src/test/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageDeserializerTest.java
./ql/src/test/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/TaskTrackerTest.java
./ql/src/test/org/apache/hadoop/hive/ql/exec/tez/InputSplitComparatorTest.java
./ql/src/test/org/apache/hadoop/hive/ql/parse/repl/CopyUtilsTest.java
./ql/src/test/org/apache/hadoop/hive/ql/parse/repl/dump/HiveWrapperTest.java
./ql/src/test/org/apache/hadoop/hive/ql/parse/repl/load/message/PrimaryToReplicaResourceFunctionTest.java
./service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java
./storage-api/src/test/org/apache/hadoop/hive/ql/util/JavaDataModelTest.java
{code}
Also I've corrected some minor issues in
{{PrimaryToReplicaResourceFunctionTest}} to make it pass.
We're expecting the following new tests to be run:
{code}
TestLazyHBaseCellMap,TestHCatBase,TestThriftCliServiceMessageSize,TestHiveStatement,TestJdbcStorageConfigManager,TestGenericJdbcDatabaseAccessor,TestJdbcInputFormat,TestQueryConditionBuilder,TestJSONMessageDeserializer,TestTaskTracker,TestInputSplitComparator,TestCopyUtils,TestHiveWrapper,TestPrimaryToReplicaResourceFunction,TestCLIServiceRestore,TestJavaDataModel
{code}
These are named {{*Test}} but are helper classes for other tests not tests on
their own:
{code}
./beeline/src/test/org/apache/hive/beeline/ProxyAuthTest.java
./itests/hive-unit/src/test/java/org/apache/hadoop/hive/UtilsForTest.java
./itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerForTest.java
./itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidatorForTest.java
./itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactoryForTest.java
./ql/src/java/org/apache/hadoop/hive/ql/log/LogDivertAppenderForTest.java
./ql/src/test/org/apache/hadoop/hive/ql/exec/vector/UDFHelloTest.java
./ql/src/test/org/apache/hadoop/hive/ql/hooks/QueryLifeTimeHookTest.java
{code}
The patch does not affect these.
> Fix misnamed tests which are not run during precommit runs.
> ------------------------------------------------------------
>
> Key: HIVE-17725
> URL: https://issues.apache.org/jira/browse/HIVE-17725
> Project: Hive
> Issue Type: Bug
> Components: Test
> Reporter: Zoltan Haindrich
> Assignee: Daniel Voros
> Attachments: HIVE-17725.1.patch
>
>
> I've just seen a testfailure for jdk9; but the test is not even executed
> during precommit runs:
> {{TaskTrackerTest}}
> I think the test classes name should match the {{\*\*/Test\*}} to be executed
> during test runs...however there seems to be quite a few... {{find . -name
> '*Test.java'}} returns a few abstracts ; but there are real test ; which are
> just misnamed...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
