[
https://issues.apache.org/jira/browse/HIVE-17629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196964#comment-16196964
]
Alan Gates commented on HIVE-17629:
-----------------------------------
SharedCache, line 576 in your patch. I don't understand why createDatabase
would return without creating the database and without an exception if it can't
get the cache. This would give the impression of success but no database would
be created. Should it fall back to RawStore? Same comments on dropDatabase,
alterDatabase, etc.
As a general question why wait for init on the cache? Why not serve queries
(obviously more slowly) while the cache loads? It seems better than making
them wait until the whole cache is loaded. I realize this is outside the scope
of this JIRA.
It seems like SharedCache should have read/write locks rather than
synchronizing on the whole class. Again, I realize this is outside the scope
of this JIRA.
> CachedStore - wait for prewarm at use time, not init time
> ---------------------------------------------------------
>
> Key: HIVE-17629
> URL: https://issues.apache.org/jira/browse/HIVE-17629
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-17629.patch
>
>
> Most of the changes are trivial, due to static changing to non-static. The
> patch basically adds lifecycle management for shared cache, and uses it to
> move prewarm to background thread, waiting for prewarm to happen at use time
> not setConf, and to make init optional (if not called, CachedStore would
> proxy the methods to rawStore, like it currently does in the ones not
> implemented).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
