[
https://issues.apache.org/jira/browse/HIVE-17743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197434#comment-16197434
]
Sahil Takiar commented on HIVE-17743:
-------------------------------------
Hey [~alangates]. I'm still using the Hadoop annotations for the
standalone-metastore. The only reason I made the Hive annotations a separate
Maven module is because the {{service-rpc}} module (which contains all the
Thrift generated code for HS2), doesn't have a dependency on {{hive-common}}.
Rather than add a dependency from {{service-rpc}} to {{hive-common}}, I just
moved the annotations to a separate Maven module call {{hive-annotation}}.
Alternatively, we could just drop our version of the annotations completely and
just use the Hadoop ones everywhere, although that means {{service-rpc}} needs
a Hadoop dependency, not sure if that matters or not.
> Add InterfaceAudience and InterfaceStability annotations for Thrift generated
> APIs
> ----------------------------------------------------------------------------------
>
> Key: HIVE-17743
> URL: https://issues.apache.org/jira/browse/HIVE-17743
> Project: Hive
> Issue Type: Sub-task
> Components: Thrift API
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Attachments: HIVE-17743.1.patch
>
>
> The Thrift generated files don't have {{InterfaceAudience}} or
> {{InterfaceStability}} annotations on them, mainly because all the files are
> auto-generated.
> We should add some code that auto-tags all the Java Thrift generated files
> with these annotations. This way even when they are re-generated, they still
> contain the annotations.
> We should be able to do this using the
> {{com.google.code.maven-replacer-plugin}} similar to what we do in
> {{standalone-metastore/pom.xml}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
