[ 
https://issues.apache.org/jira/browse/HIVE-17746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197672#comment-16197672
 ] 

Vineet Garg commented on HIVE-17746:
------------------------------------

Hi [~pvary]. Thanks for taking care of this! The changes are good and are 
expected.  +1.


> Regenerate spark_explainuser_1.q.out
> ------------------------------------
>
>                 Key: HIVE-17746
>                 URL: https://issues.apache.org/jira/browse/HIVE-17746
>             Project: Hive
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 3.0.0
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: HIVE-17746.patch
>
>
> There is 2 changes in  spark_explainuser_1.q.out:
> 1., After HIVE-17465, the row numbers are different in the explain plans. 
> [~vgarg], [~ashutoshc]: Could you please check, wether it is an intended 
> change?
> 2., After HIVE-17535, CBO optimization turned on and the output of the 
> following query changed:
> {code:title=Query}
> explain select explode(array('a', 'b'));
> {code}
> {code:title=Original}
>  POSTHOOK: query: explain select explode(array('a', 'b'))
>  POSTHOOK: type: QUERY
>  Plan not optimized by CBO.
>  
>  Stage-0
>    Fetch Operator
>      limit:-1
>     UDTF Operator [UDTF_2]
>       function name:explode
>       Select Operator [SEL_1]
>         Output:["_col0"]
>         TableScan [TS_0]
> {code}
> {code:title=New}
>  POSTHOOK: query: explain select explode(array('a', 'b'))
>  POSTHOOK: type: QUERY
>  Plan optimized by CBO.
>  
>  Stage-0
>    Fetch Operator
>      limit:-1
>     Select Operator [SEL_3]
>       Output:["_col0"]
>       UDTF Operator [UDTF_2]
>         function name:explode
>         Select Operator [SEL_1]
>           Output:["_col0"]
>           TableScan [TS_0]
> {code}
> This 2nd change does not look like a successful optimization for me. Is it 
> planned :)
> If you think these are planned changes, then I think it would be good to 
> update the golden file.
> Thanks,
> Peter



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to