[ 
https://issues.apache.org/jira/browse/HIVE-17747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209810#comment-16209810
 ] 

Mithun Radhakrishnan commented on HIVE-17747:
---------------------------------------------

I'm regret being late to this party, I truly do.

The code in {{hive/metastore/messaging}} mirrors that in 
{{hcatalog/messaging}}, which uses sparse messages. The entire motivation 
behind keeping the messages devoid of the actual Thrift object ({{Database}}, 
{{Table}}, {{Partition}}, {{StorageDescriptor}}) is that they bloat the size of 
the message. It is not uncommon for us in production to have >1000 partitions 
added in a single {{addPartitions()}} call. {{Partition}} objects tend to 
possess a lot of redundant information, causing the message size to become 
enormous.

It looks like that ship sailed with HIVE-15522. Your solution here is 
consistent with HIVE-15522, so it should stand. :/ I'll raise a separate JIRA 
to deal with sparser messages.

> HMS DropTableMessage should include the full table object
> ---------------------------------------------------------
>
>                 Key: HIVE-17747
>                 URL: https://issues.apache.org/jira/browse/HIVE-17747
>             Project: Hive
>          Issue Type: Improvement
>          Components: HCatalog, Metastore
>    Affects Versions: 2.3.0
>            Reporter: Dan Burkert
>            Assignee: Dan Burkert
>             Fix For: 3.0.0, 2.4.0
>
>         Attachments: HIVE-17747.0.patch
>
>
> I have a notification log follower use-case which requires accessing the 
> parameters of dropped tables, so it would be useful if the {{DROP_TABLE}} 
> events in the notification log included the full table object, as the create 
> and alter events do.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to