[
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234080#comment-16234080
]
Alan Gates commented on HIVE-17812:
-----------------------------------
How about the following:
In this patch I change {{IHMSHander getHandler()}} to {{IHMSHandler
getIHMSHandler()}}. In the next patch (which will include HiveMetaStore.java
and thus HMSHandler) I will add back {{HMSHandler getHandler()}} and mark it
deprecated as you suggest. I don't need to add back the constructor since only
the metastore should be constructing these events. I will do this in the next
patch to avoid pulling in HiveMetaStore.java into this already large (and
mostly reviewed) patch.
As for HMSHandler being public, you are correct it's not. In fact IHMSHandler
is marked private. This is weird given that a public interface is handing out
references to them. I propose as part of this change we move IHMSHandler to
public/evolving, noting that it is used by listeners, and specifically mark
HMSHandler as private.
I don't believe any of these changes will require us to recompile clients. But
any listeners who call {{getHandler().getHiveConf()}} will have to be
recompiled.
Seem reasonable?
> Move remaining classes that HiveMetaStore depends on
> -----------------------------------------------------
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move
> HiveMetaStore itself. These include NotificationListener and
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
