[ 
https://issues.apache.org/jira/browse/HIVE-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246104#comment-16246104
 ] 

Janaki Lahorani commented on HIVE-17942:
----------------------------------------

@akolb Changing AlterHandler to be not configurable is a significant change - 
potentially backward incompatible.  There can be other implementations that can 
be used other than HiveAlterHandler.
https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L485
Also, though this can be considered as a good code cleanup, it is in theory 
cosmetic and not needed for this bug fix.
And, the story about the way HMS Handler works with DDL handlers is a design 
detail that is common to all DDL handlers, hence doesn't necessarily belong in 
any DDL handler, but rather in a design document or possibly in HMS Handler 
implementation, which again IMHO outside the scope of this bug fix.

There is an example in the test.

Configuration changes within a connection is to be made using
set <parameter>=value
If the configuration change is to be effective in HMS it is to be prepended 
with metaconf:
set metaconf:<parameter>=value
Example:
set metaconf:hive.metastore.disallow.incompatible.col.type.changes=false


> HiveAlterHandler not using conf from HMS Handler
> ------------------------------------------------
>
>                 Key: HIVE-17942
>                 URL: https://issues.apache.org/jira/browse/HIVE-17942
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.1.1
>            Reporter: Janaki Lahorani
>            Assignee: Janaki Lahorani
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17942.1.patch, HIVE-17942.2.patch, 
> HIVE-17942.3.patch, HIVE-17942.4.patch, HIVE-17942.5.patch
>
>
> When HiveAlterHandler looks for conf, it is not getting the one from thread 
> local.  So, local changes are not visible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to