[ 
https://issues.apache.org/jira/browse/HIVE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254606#comment-16254606
 ] 

Sergey Shelukhin edited comment on HIVE-18056 at 11/16/17 1:42 AM:
-------------------------------------------------------------------

Hmm... I don't understand the new logic. waitForInitAndBlock seems to be a dup 
of waitForInit.
The difference is that waitForInit doesn't sleep forever to avoid common bugs 
we've seen with the code that does sleep forever when some changes are made 
later and the state is modified without waking it up. It still does wait 
forever (via the while loop), sleeping 100ms on every iteration and re-checking 
the state. Notify is a nice addition.
Also, Wrapper.get already calls waitForInit, so there shouldn't be need to also 
call waitForInitAndBlock (or if there's a bug in waitForInit that makes it not 
wait forever, it should be fixed).


was (Author: sershe):
Hmm... I don't understand the new logic. waitForInitAndBlock seems to be a dup 
of waitForInit.
The difference is that waitForInit doesn't sleep forever to avoid common bugs 
we've seen with the code that does sleep forever when some changes are made 
later and the state is modified without waking it up. It still does wait 
forever (via the while loop), sleeping 100ms on every iteration and re-checking 
the state.
Wrapper.get already calls waitForInit, so there shouldn't be need to also call 
waitForInitAndBlock (or if there's a bug in waitForInit that makes it not wait 
forever, it should be fixed).

> CachedStore: Have a whitelist/blacklist config to allow selective caching of 
> tables/partitions and allow read while prewarming
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-18056
>                 URL: https://issues.apache.org/jira/browse/HIVE-18056
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 3.0.0
>            Reporter: Vaibhav Gumashta
>            Assignee: Vaibhav Gumashta
>         Attachments: HIVE-18056.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to