[ 
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283911#comment-16283911
 ] 

Alan Gates commented on HIVE-17981:
-----------------------------------

ColumnStatistics were pretty in depth and I didn't need them for the tests I 
was moving, and it wasn't clear to me users would need them, so I didn't bother.

I don't know why I left out Function.

The WM* classes didn't exist yet when I wrote this patch.

I can't see a reason to hold this patch to add more builders.  It makes more 
sense to me to commit this and then add the others in follow JIRAs.

> Create a set of builders for Thrift classes
> -------------------------------------------
>
>                 Key: HIVE-17981
>                 URL: https://issues.apache.org/jira/browse/HIVE-17981
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Standalone Metastore
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>              Labels: pull-request-available
>         Attachments: HIVE-17981.patch
>
>
> Instantiating some of the Thrift classes is painful.  Consider building a 
> {{Table}} object, which requires a {{StorageDescriptor}}, which requires a 
> {{SerDeInfo}} and a list of {{FieldInfo}}.  All that is really necessary for 
> a Table in the most simple case is a name, a database, and some columns.  But 
> currently creating even a simple Table requires 20+ lines of code.  This is 
> particularly painful in tests.  
> I propose to add a set of builders.  These will come with reasonable defaults 
> to minimize the boilerplate code.  They will also include simple methods for 
> common operations (like adding columns, or a parameter) without requiring the 
> user to create all the sub-objects (like {{StorageDescriptor}}).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to