Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/14#discussion_r97722648
--- Diff: core/src/main/java/hivemall/optimizer/EtaEstimator.java ---
@@ -157,4 +158,34 @@ public static EtaEstimator get(@Nullable CommandLine
cl, float defaultEta0)
return new InvscalingEtaEstimator(eta0, power_t);
}
+ @Nonnull
+ public static EtaEstimator get(@Nonnull final Map<String, String>
options)
+ throws IllegalArgumentException {
+ final String etaName = options.get("eta");
+ if(etaName == null) {
+ return new FixedEtaEstimator(1.f);
--- End diff --
Absolutely. Changed to `InvscalingEtaEstimator(0.1f, 0.1d)` when `eta` is
not provided. (cc: @maropu )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
