Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/71#discussion_r112865163
  
    --- Diff: core/src/main/java/hivemall/utils/math/MathUtils.java ---
    @@ -401,4 +401,13 @@ public static double logsumexp(@Nonnull final double[] 
arr, final double max) {
             return Math.log(logsumexp) + max;
         }
     
    +    @Nonnull
    +    public static float[] normalize(@Nonnull final float[] arr) {
    --- End diff --
    
    `sum` is l1norm? Then, remove this to `l1normalize`.
    
    `l1norm` should be the sum of the **absolute** values of the columns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to