GitHub user takuti opened a pull request:
https://github.com/apache/incubator-hivemall/pull/92
[HIVEMALL-5] Java code formatter
## What changes were proposed in this pull request?
In order to make contribution to Hivemall more easier, we need to prepare
contribution guide as soon as possible. This PR is the first step toward
publishing a complete document on https://hivemall.incubator.apache.org
For now, I added (temporal) contribution guide to README and require
contributors to follow specific cording conventions hereafter.
## What type of PR is it?
Documentation?
## What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-5
---
Originally, `eclipse-style.xml` was created based on google's coding
conventions. However, in this PR, I suggest to follow coding conventions of
Hive hereafter; since Hivemall clearly stands on Hive, following its
conventions should be the most reasonable choice.
@myui If you strongly want to use different kind of conventions, I will
update this PR so.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takuti/incubator-hivemall hive-formatter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit 2ddc95e1df4448f8b89a127e119e96416e732b59
Author: Takuya Kitazawa <[email protected]>
Date: 2017-07-01T13:37:24Z
Use Hive eclipse formatting style
commit 83cf09b6985fe83c6e9499887dca75f24615b0d6
Author: Takuya Kitazawa <[email protected]>
Date: 2017-07-01T13:39:23Z
Apply formatter
commit cff7ca82e85eb59829594403ec9e0bad7b0e91f7
Author: Takuya Kitazawa <[email protected]>
Date: 2017-07-01T13:54:03Z
Add temporal contribution guide to README
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
