Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/111#discussion_r136027874
--- Diff: core/src/main/java/hivemall/recommend/SlimUDTF.java ---
@@ -235,16 +400,12 @@ private void train(int i, Map<?, ?> Ri, Map<?, ?>
topKRatesOfI, int j, Map<?, ?>
update = 0.;
}
}
-
- this.loss += errs;
- this.W.unsafeSet(i, j, update);
+ return update;
}
- public void resetLoss() {
- this.loss = 0.d;
- }
+ private final void runIterativeTraining() throws HiveException {
--- End diff --
Remove `final` and make `SlimUDTF` itself final.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
