Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/148#discussion_r183642989
  
    --- Diff: tools/hivemall-docs/pom.xml ---
    @@ -0,0 +1,173 @@
    +<!--
    +  Licensed to the Apache Software Foundation (ASF) under one
    +  or more contributor license agreements.  See the NOTICE file
    +  distributed with this work for additional information
    +  regarding copyright ownership.  The ASF licenses this file
    +  to you under the Apache License, Version 2.0 (the
    +  "License"); you may not use this file except in compliance
    +  with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing,
    +  software distributed under the License is distributed on an
    +  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  KIND, either express or implied.  See the License for the
    +  specific language governing permissions and limitations
    +  under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <parent>
    +           <groupId>org.apache.hivemall</groupId>
    +           <artifactId>hivemall-tools</artifactId>
    +           <version>0.5.1-incubating-SNAPSHOT</version>
    +           <relativePath>../pom.xml</relativePath>
    +   </parent>
    +
    +   <artifactId>hivemall-tool-docs</artifactId>
    +   <name>Hivemall Documentation Tool</name>
    +   <packaging>jar</packaging>
    +
    +   <properties>
    +           <main.basedir>${project.parent.parent.basedir}</main.basedir>
    +   </properties>
    +
    +   <dependencies>
    +           <!-- hivemall dependencies -->
    +           <dependency>
    +                   <groupId>org.apache.hivemall</groupId>
    +                   <artifactId>hivemall-core</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>compile</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.hivemall</groupId>
    +                   <artifactId>hivemall-nlp</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>compile</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.hivemall</groupId>
    +                   <artifactId>hivemall-xgboost</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>compile</scope>
    +           </dependency>
    +
    +           <!-- compile scope -->
    +           <!-- hive-exec dependency with compile scope enables us to run 
the main class in IntelliJ -->
    +           <dependency>
    +                   <groupId>org.apache.hive</groupId>
    +                   <artifactId>hive-exec</artifactId>
    +                   <scope>compile</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.reflections</groupId>
    +                   <artifactId>reflections</artifactId>
    +                   <version>0.9.10</version>
    +                   <scope>compile</scope>
    +           </dependency>
    +   </dependencies>
    +
    +   <build>
    +           <plugins>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-jar-plugin</artifactId>
    +                           <configuration>
    +                                   <archive>
    +                                           <manifest>
    +                                                   
<mainClass>hivemall.docs.HivemallDocs</mainClass>
    +                                           </manifest>
    +                                   </archive>
    +                           </configuration>
    +                   </plugin>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    --- End diff --
    
    @takuti Why not directly update these files?
    
    `docs/gitbook/misc/funcs.md`
    `docs/gitbook/misc/generic_funcs.md`


---

Reply via email to