Makoto Yui created HIVEMALL-211:
-----------------------------------
Summary: Fixed Optimizer for regularization updates
Key: HIVEMALL-211
URL: https://issues.apache.org/jira/browse/HIVEMALL-211
Project: Hivemall
Issue Type: Bug
Affects Versions: 0.5.0
Reporter: Makoto Yui
Assignee: Makoto Yui
Fix For: 0.5.2
In
https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/optimizer/Optimizer.java#L73
{code:java}
float g = _reg.regularize(oldWeight, gradient);
float delta = computeDelta(weight, g);
float newWeight = oldWeight - _eta.eta(_numStep) * delta;
{code}
should be
{code:java}
float delta = computeDelta(weight, gradient);
float newWeight = oldWeight - _eta.eta(_numStep) * _reg.regularize(oldWeight,
delta);
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
