Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/160#discussion_r214800712
  
    --- Diff: core/src/main/java/hivemall/tools/math/IsInfiniteUDF.java ---
    @@ -0,0 +1,33 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package hivemall.tools.math;
    +
    +import org.apache.hadoop.hive.ql.exec.Description;
    +import org.apache.hadoop.hive.ql.exec.UDF;
    +
    +@Description(name = "is_infinite", value = "_FUNC_(x) - Determine if x is 
infinite.")
    +public final class IsInfiniteUDF extends UDF {
    +    public Boolean evaluate(Double num) {
    +        if (num == null) {
    +            return null;
    +        } else {
    +            return !num.isNaN() && num.isInfinite();
    --- End diff --
    
    Is `!num.isNaN() &&` required? 


---

Reply via email to