Takuya Kitazawa created HIVEMALL-234:
----------------------------------------
Summary: Fix mismatched default value between EtaEstimator and UDF
option description
Key: HIVEMALL-234
URL: https://issues.apache.org/jira/browse/HIVEMALL-234
Project: Hivemall
Issue Type: Improvement
Reporter: Takuya Kitazawa
Assignee: Takuya Kitazawa
UDF option description sometimes tells a lie:
* `train_mf_sgd` says default value of `eta0` is 0.2:
[https://github.com/apache/incubator-hivemall/blob/7b61a3be8178fef40154f4009fef2989a9fd4c49/core/src/main/java/hivemall/mf/MatrixFactorizationSGDUDTF.java#L44]
* But `EtaEstimator` actually uses 0.1 as a default value:
[https://github.com/apache/incubator-hivemall/blob/31932fd7c63f9bb21eba8959944d03f280b6deb9/core/src/main/java/hivemall/optimizer/EtaEstimator.java#L153]
In order to avoid those mismatched cases, define EtaEstimator's default values
as constants, and directly refer them from `getOptions`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
