myui opened a new pull request #185: [HIVEMALL-243] Fix nominal variable handling in DecisionTree and RegressionTre URL: https://github.com/apache/incubator-hivemall/pull/185 ## What changes were proposed in this pull request? For NOMINAL variable, the maximum attribute index 'm' is used for computing splits. This cause performance issues for sparse nominal variables. So, revise this handling for a better performance. https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/smile/classification/DecisionTree.java#L703 ## What type of PR is it? Improvement ## What is the Jira issue? (Put link here and add [HIVEMALL-*Jira number*] in PR title, e.g., [HIVEMALL-533]) ## How was this patch tested? https://issues.apache.org/jira/browse/HIVEMALL-243 ## Checklist - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit? - [ ] Did you run system tests on Hive (or Spark)?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
