[
https://issues.apache.org/jira/browse/HIVEMALL-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817087#comment-16817087
]
ASF GitHub Bot commented on HIVEMALL-246:
-----------------------------------------
myui commented on pull request #190: [HIVEMALL-246] Add feature name validation
in feature UDF
URL: https://github.com/apache/incubator-hivemall/pull/190
## What changes were proposed in this pull request?
This PR adds feature name validation in feature UDF
feature(name, value) should validate name not to include ":". Fail-fast
behavior is preferable.
## What type of PR is it?
Hot Fix
## What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-246
## How was this patch tested?
unit tests
## Checklist
- [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for
your commit?
- [ ] Did you run system tests on Hive (or Spark)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add validation for feature UDF
> ------------------------------
>
> Key: HIVEMALL-246
> URL: https://issues.apache.org/jira/browse/HIVEMALL-246
> Project: Hivemall
> Issue Type: Improvement
> Affects Versions: 0.5.2
> Reporter: Makoto Yui
> Assignee: Makoto Yui
> Priority: Minor
> Fix For: 0.6.0
>
>
> feature(name, value) should validate name not to include ":".
> Fail-fast behavior is preferable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
