mattcasters commented on issue #3169: URL: https://github.com/apache/hop/issues/3169#issuecomment-1811494575
ProjectsGuiPlugin:576 : `hopGui.getDisplay().getActiveShell()` is null so the error dialog doesn't pop up. Original error comes from: ``` java.lang.IllegalArgumentException: Argument cannot be null at org.eclipse.swt.SWT.error(SWT.java:4899) at org.eclipse.swt.SWT.error(SWT.java:4833) at org.eclipse.swt.SWT.error(SWT.java:4804) at org.eclipse.swt.widgets.Dialog.error(Dialog.java:202) at org.eclipse.swt.widgets.Dialog.checkParent(Dialog.java:168) at org.eclipse.swt.widgets.Dialog.<init>(Dialog.java:131) at org.apache.hop.ui.core.dialog.MessageBox.<init>(MessageBox.java:59) at org.apache.hop.projects.gui.ProjectsGuiPlugin.askAboutProjectRefresh(ProjectsGuiPlugin.java:181) at org.apache.hop.projects.gui.ProjectsGuiPlugin.editEnvironment(ProjectsGuiPlugin.java:569) at org.apache.hop.projects.gui.ProjectsGuiPlugin.editSelectedEnvironment(ProjectsGuiPlugin.java:636) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.apache.hop.ui.core.gui.BaseGuiWidgets.lambda$getListener$1(BaseGuiWidgets.java:216) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5855) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1529) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:5065) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4517) at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:473) at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:351) ``` so ProjectsGuiPlugin, again `hopGui.getDisplay().getActiveShell()`. Broken by #2944, needs to be hardened or code reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
